On 8 November 2017 at 11:32, KONRAD Frederic <[email protected]> wrote: > We want to add this model to the xlnx-zynqmp board so let's make > CadenceTTCState available in an header file. > > Signed-off-by: KONRAD Frederic <[email protected]> > --- > hw/timer/cadence_ttc.c | 35 +----------------------- > include/hw/timer/cadence_ttc.h | 61 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 62 insertions(+), 34 deletions(-) > create mode 100644 include/hw/timer/cadence_ttc.h > > diff --git a/hw/timer/cadence_ttc.c b/hw/timer/cadence_ttc.c > index 03f5b9c..bb4a5ef 100644 > --- a/hw/timer/cadence_ttc.c > +++ b/hw/timer/cadence_ttc.c > @@ -16,9 +16,7 @@ > * with this program; if not, see <http://www.gnu.org/licenses/>. > */ > > -#include "qemu/osdep.h" > -#include "hw/sysbus.h" > -#include "qemu/timer.h" > +#include "hw/timer/cadence_ttc.h"
Something's gone wrong here. osdep.h should always be the first header in any .c file, and it should never be included by any other .h file. thanks -- PMM
