Am 16.11.2017 um 03:28 schrieb Mao Zhongyi: > Cc: Peter Maydell <[email protected]> > Cc: Jason Wang <[email protected]> > Cc: Zhang Chen <[email protected]> > Cc: Li Zhijian <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Fixes: 8ec14402029d783720f4312ed8a925548e1dad61 > Reported-by: Peter Maydell <[email protected]> > Reported-by: Paolo Bonzini <[email protected]> > Signed-off-by: Mao Zhongyi <[email protected]> > --- > net/colo-compare.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/colo-compare.c b/net/colo-compare.c > index ccdcba2..1ce195f 100644 > --- a/net/colo-compare.c > +++ b/net/colo-compare.c > @@ -179,7 +179,7 @@ static int packet_enqueue(CompareState *s, int mode, > Connection **con) > "drop packet"); > } > } > - con = &conn; > + *con = conn; > > return 0; > }
The patch is definitely needed if the new function parameter con should work. It also fixes a gcc compiler warning: net/colo-compare.c:139:67: warning: parameter ‘con’ set but not used [-Wunused-but-set-parameter] I think using -Wextra would be really good to catch such bugs earlier. Regards, Stefan
