On 2017-11-14 16:06, Alberto Garcia wrote:
> On Fri 10 Nov 2017 09:31:11 PM CET, Max Reitz wrote:
>> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s,
>> Qcow2Cache *c)
>> +{
>> + if (c == s->refcount_block_cache) {
>> + return "refcount block";
>> + } else if (c == s->l2_table_cache) {
>> + return "L2 table";
>> + } else {
>> + /* Do not abort, because this is not critical */
>> + return "unknown";
>> + }
>> +}
>
> Why is an unknown cache not critical?Because this is debugging information. I know others disagree with my opinion that I'd rather not abort qemu just because someone forgot to add a 'return "foo";' here when adding a new cache, but that's my opinion so I wanted to at least be told by someone that we should abort here before doing it. Max
signature.asc
Description: OpenPGP digital signature
