On Mon, Nov 06, 2017 at 10:39:24AM +0000, Gonglei (Arei) wrote: > Hi guys, > > What a long time iteration it is. > > Hoping this is the final version if no big arguments exist as > discussed with Stefan at KVM Forum 2017 this October. People > can submit patches to fix some grammar issues or little problems, > and then Xin' can submit the asymmetric crypto services spec > based on this version.
Yes, I support merging the virtio-crypto spec as soon as technical concerns are addressed. English language fixes are more efficiently done as follow-up patches from native speakers. This way we avoid extra iterations that might themselves add new English language issues. I hope others see it the same way. If not, speak up now. BTW, I am committing myself to proofread the document that goes up for vote and will send follow-up patches. > I'll start a vote for virtio crypto device after one week. :) > > Please reviewing in time, thanks a lot! > > > Regards, > -Gonglei > > > > -----Original Message----- > > From: longpeng > > Sent: Monday, November 06, 2017 2:59 PM > > To: [email protected]; [email protected] > > Cc: Luonengjun; [email protected]; [email protected]; > > [email protected]; [email protected]; Jani Kokkonen; > > [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected]; > > Huangweidong (C); [email protected]; [email protected]; > > [email protected]; Gonglei (Arei); [email protected]; wangxin > > (U); Zhoujian (jay); longpeng > > Subject: [v21 RESEND 0/2] virtio-crypto: virtio crypto device specification > > > > This is the specification about the new virtio crypto device. > > > > --- > > v21 -> v20 > > - rename 'queue_id' to 'reserved' [Halil] > > - redescribe the format of the structures which using 'union' > > in the previous version [Halil] > > > > v20 -> v19 > > - fix some typos and grammar fixes [Halil] > > - make queue_id reserved [Halil] > > - remove 'Steps of Operation' > > > > v19 -> v18: > > - fix some typos and grammar fixes [Stefan, Halil] > > - rename VIRTIO_CRYPTO_F_STATELESS_MODE to > > VIRTIO_CRYPTO_F_MUX_MODE > > - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] > > - refactor and redescribe the controlq/dataq request's format > > of mux mode. [Halil] > > - other small fixes. [Halil] > > > > v18 -> v17: > > - fix many English grammar problems suggested by Stefan, Thanks a lot! > > > > v17 -> v16: > > - Some grammar fixes [Stefan, Halil, Michael] > > - add a section named "Supported crypto services" in order to explain bit > > numbers and valuse clearly. [Halil, Cornelia] > > - avoid word reptition [Halil] > > - rename non-session mode to stateless mode [Halil] > > - change descriptions for all elements in struct virtio_crypto_config > > [Halil] > > - add Halil as a reviewer in the ackonwledgement part, thanks for his work. > > - other fixes here and there. > > > > Changes since v15: > > - use feature bits for non-session mode in order to keep compatibility with > > pre-existing code. [Halil & Michael] > > - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all > > other > > non-session mode feature bits. > > - fix some typos. [Stefan] > > - introduce struct virtio_crypto_op_data_req_mux to support both session > > and non-session based crypto operations and keep compatibility with > > pre-existing code. > > > > Changes since v14: > > - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] > > - correct a sentence about dataqueue and controlq in the first paragraph. > > [Halil] > > - change a MAY to MUST about max_dataqueues. [Halil] > > - add non-session mode support > > a) add four features for different crypto services to identify wheather > > support session mode. > > b) rewrite some > > > > For pervious versions of virtio crypto spec, Pls see: > > > > [v18]: > > https://www.mail-archive.com/[email protected]/msg444897.html > > > > [v14]: > > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html > > > > [v13]: > > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html > > > > For more information, please see: > > http://qemu-project.org/Features/VirtioCrypto > > > > --- > > Gonglei (2): > > virtio-crypto: Add virtio crypto device specification > > virtio-crypto: Add conformance clauses > > > > acknowledgements.tex | 3 + > > conformance.tex | 29 + > > content.tex | 2 + > > virtio-crypto.tex | 1426 > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 1460 insertions(+) > > create mode 100644 virtio-crypto.tex > > > > -- > > 1.8.3.1 > > > >
signature.asc
Description: PGP signature
