Peter Maydell <[email protected]> writes: > On 11 October 2017 at 05:33, Jiang Biao <[email protected]> wrote: >> There are some rare cases which need external declarations in .c >> files. patchew.org and checkpatch.pl will complain errors on >> patches for these declarations. >> >> Degrade ERROR to WARN to erase the error complaints taking >> checkpatch.pl in kernel as reference. >> >> Signed-off-by: Jiang Biao <[email protected]> >> --- >> scripts/checkpatch.pl | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > I'd rather not drop this to a warning for the sake of a single > use case that's already in the tree (and which if you really
Concur. Rare false positives from checkpatch are tolerable. > cared about you could work around by putting the link_error() > declaration in a header file I suppose, though I wouldn't > bother personally.)
