On 03.11.2017 13:30, Marc-André Lureau wrote: > Hi Thomas > > On Fri, Nov 3, 2017 at 1:01 PM, Thomas Huth <[email protected]> wrote: >> On 03.11.2017 12:49, Marc-André Lureau wrote: >>> Hi Daniel >>> >>> On Fri, Oct 27, 2017 at 8:17 PM, Daniel Henrique Barboza >>> <[email protected]> wrote: >>>> The device vmcoreinfo depends on the fw_cfg device to work, a device >>>> that isn't available in most ppc64 machines. This makes device-crash-test >>>> spams the following error when running with qemu-system-ppc64: >>>> >>>> "INFO: log: qemu-system-ppc64: -device vmcoreinfo: vmcoreinfo device >>>> requires fw_cfg with DMA" [...] >> It's not only about ppc64 - this problem exists also on most other >> targets, e.g.: >> >> $ m68k-softmmu/qemu-system-m68k -M none -device vmcoreinfo >> qemu-system-m68k: -device vmcoreinfo: vmcoreinfo device requires fw_cfg >> with DMA >> >> So for the device-crash-test script, I think it would make more sense to >> add a generic, machine-independent entry for this. >> >> Additionally, I think it's also a bad idea to blindly add this >> vmcoreinfo device to all targets! We should only add it to the targets >> that actually feature the fw_cfg device with DMA, so we need a proper >> CONFIG_xxx switch for this. Marc-André or Daniel, do you have time to >> work on such a patch? Otherwise, I can have a look at this, too. > > Ah the DMA interface is only available on x86 & arm virt apparently. I > thought it would be more widely available. > > I can add a CONFIG_FW_CFG_DMA, set by x86)64-softmuu & arm-softmmu, > and make vmcoreinfo depend on it. Would that be good enough?
Yes, that sounds good to me! Thanks, Thomas
