Peter Xu <[email protected]> wrote: > On Mon, Oct 16, 2017 at 12:32:10AM -0700, [email protected] wrote: >> Hi, >> >> This series failed build test on s390x host. Please find the details below. >> >> Type: series >> Subject: [Qemu-devel] [PATCH v3 00/32] Migration: postcopy failure recovery >> Message-id: [email protected] >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> # Testing script will be invoked under the git checkout with >> # HEAD pointing to a commit that has the patches applied on top of "base" >> # branch >> set -e >> echo "=== ENV ===" >> env >> echo "=== PACKAGES ===" >> rpm -qa >> echo "=== TEST BEGIN ===" >> CC=$HOME/bin/cc >> INSTALL=$PWD/install >> BUILD=$PWD/build >> echo -n "Using CC: " >> realpath $CC >> mkdir -p $BUILD $INSTALL >> SRC=$PWD >> cd $BUILD >> $SRC/configure --cc=$CC --prefix=$INSTALL >> make -j4 >> # XXX: we need reliable clean up >> # make check -j4 V=1 >> make install >> === TEST SCRIPT END === > > [...] > >> CC migration/postcopy-ram.o >> CC migration/qjson.o >> CC migration/block.o >> CC net/net.o >> CC net/queue.o >> /var/tmp/patchew-tester-tmp-nm4b3qpv/src/migration/postcopy-ram.c: In >> function ‘postcopy_ram_fault_thread’: >> /var/tmp/patchew-tester-tmp-nm4b3qpv/src/migration/postcopy-ram.c:553:13: >> error: ignoring return value of ‘read’, declared with attribute >> warn_unused_result [-Werror=unused-result] >> read(mis->userfault_event_fd, &tmp64, 8); >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Need to capture read() return code. Fixed. > > I captured this as well using "make docker-test-build@fedora". Anyone > knows why I didn't encounter this on my Fedora 26 host? My gcc > version: 7.2.1 20170915 (Red Hat 7.2.1-2), which seems to be quite new > as well.
CFLAGS -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g I think this is the magic bits that you are missing. Add this to your CFLAGS. Later, Juan. > Would also appreciate if anyone can provide a minimum docker test > subset (TEST & IMAGE) that I'd run before posting patches. TIA. > >> cc1: all warnings being treated as errors >> /var/tmp/patchew-tester-tmp-nm4b3qpv/src/rules.mak:66: recipe for >> target 'migration/postcopy-ram.o' failed >> make: *** [migration/postcopy-ram.o] Error 1 >> make: *** Waiting for unfinished jobs.... >> === OUTPUT END === >> >> Test command exited with code: 2 >> >> >> --- >> Email generated automatically by Patchew [http://patchew.org/]. >> Please send your feedback to [email protected]
