On 26 October 2017 at 08:45, Alexey Kardashevskiy <[email protected]> wrote: > Submodules change once/twice a year so we could live quite happily without > this automation imho.
This is a significant underestimate. The openbios submodule alone has been updated 12 times this year. > What if I do not want submodules to be updated in > order to reproduce some bug and confirm that the newer version of submodule > has fixed it? The only thing we support is "use the version of the submodule that goes with the git commit of QEMU that they're supposed to go with". The only reason we have this automation at all is that git submodule is a broken design that doesn't update the submodule automatically on git checkout/git branch etc. I'm not a huge fan of this automation as we have it at the moment, but we do need to do something just to work around the terrible terrible stock git behaviour :-( > btw I looked now to my tree with upstream QEMU and dtc in that tree is 8 > month old (v1.4.4 and there is v1.4.5 available). Is not it supposed to > update to something more recent automatically? git-submodule.sh does not do > checkout or pull. We update the submodules when we need to update them (which for dependencies like dtc is usually "when we have some requirement that mandates a newer version".) thanks -- PMM
