On 13 October 2017 at 12:14, Marc-André Lureau <[email protected]> wrote: > Hi > > On Wed, Oct 11, 2017 at 9:47 PM, Stefan Berger > <[email protected]> wrote: >> EBADMSG was only added to OpenBSD very recently. To make QEMU compilable >> on older OpenBSD versions use EMSGSIZE instead when a mismatch between >> number of received bytes and message size indicated in the header was >> found. >> >> Return -EMSGSIZE and convert all other errnos in the same functions to >> return the negative errno. >> >> Signed-off-by: Stefan Berger <[email protected]> > > Reviewed-by: Marc-André Lureau <[email protected]> > > > Looks good to me, > but given that the return value isn't used, perhaps you could have > changed the function to return a bool success instead?
AIUI this is just test code, so we probably don't gain too much from extensively bikeshedding it. (Having said that, I can't resist asking why it's not in tests/ :-)) thanks -- PMM
