On Tue, Oct 10, 2017 at 7:48 AM, Edgar E. Iglesias <[email protected]> wrote: > On Mon, Oct 09, 2017 at 05:12:39PM -0700, Alistair Francis wrote: >> On Sun, Oct 8, 2017 at 3:20 PM, Edgar E. Iglesias >> <[email protected]> wrote: >> > On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair Francis wrote: >> >> >> >> This series adds the ZynqMP Power Management Unit (PMU) machine with basic >> >> functionality. >> >> >> >> The machine only has the >> >> - CPU >> >> - Memory >> >> - Interrupt controller >> >> - IPI device >> >> >> >> connected, but that is enough to run some of the ROM and firmware >> >> code on the machine >> >> >> >> The series also adds the IPI device and connects it to the ZynqMP ARM >> >> side and the ZynqMP PMU. These IPI devices don't connect between the ARM >> >> and MicroBlaze instances though. >> >> >> >> v3: >> >> - Add the interrupt controller >> >> - Replace some of the error_fatals with errp >> >> - Fix the PMU CPU name >> > >> > Hi Alistair, >> > >> > >> > Sorry for the super long delay... >> > >> > I think this mostly looks good but I was wondering if we really need >> > to have a board specific (zcu102) PMU? >> >> It doesn't have to be board specific. What I wanted though was an SoC >> and a machine so that maybe one day we could add the PMU SoC to the >> ARM ZCU102 machine. After that it was hard to think of a name to >> differentiate the SoC and the machine. Do you have a recommendation on >> names? > > > Hi Alistair, > > Yes, I agree with your approach but I got a little confused by the names. > > I think all the stuff that is inside the PMU subsystem architecture-wise > should have generic PMU names (no ZCU102). I.e the ROM, the RAM, the IOModule, > interrupt controller etc.
Ok I can rename them to the ZynqMP PMU (the machine/board) and the ZynqMP PMU SoC. Does that work? > > The IPI block can be outside of the PMU module and be instantiated by the > board or perhaps better if we could reuse some of the ZynqMP modules > instantiated by the ZCU102 machine to get a CPU-less PS for the PMU > to interact with. Or something along those lines. > How does that sound?> I'm a little unclear what you mean here. Thanks, Alistair > Best regards, > Edgar >
