Quoting Eric Blake (2017-10-09 13:11:28) > On 10/09/2017 12:06 PM, Michael Roth wrote: > > device_unparent(dev, ...) is called when a device is unparented, > > either directly, or as a result of a parent device being > > finalized, and handles some final cleanup for the device. Part > > of this includes emiting a DEVICE_DELETED QMP event to notify > > management, which includes the device's path in the composition > > tree as provided by object_get_canonical_path(). > > > > > +++ b/hw/core/qdev.c > > @@ -928,6 +928,13 @@ static void device_set_realized(Object *obj, bool > > value, Error **errp) > > goto post_realize_fail; > > } > > > > + /* > > + * always free/re-initialize here since the value cannot be > > cleaned up > > + * in device_unrealize due to it's usage later on in the unplug > > path > > s/it's/its/ (remember, "it's" is only appropriate if "it is" or "it has" > can be substituted in its place; otherwise you meant the possessive "its")
Thanks, just inattentiveness on my part. Will send a v3 soon if there are no other comments. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org >
