On Sun, Sep 24, 2017 at 03:47:39PM +0100, Mark Cave-Ayland wrote: > Whilst looking at implementing another DBDMA device for the Mac machines > I noticed a couple of things: firstly there were some unused fields still > in DBDMAState, and secondly the existing code still used global functions > to register DMA channels and handle the relationship between macio IDE and > DBDMA. > > This patchset removes the now-unused fields from DBDMA state, QOMifys the > DBDMA device, uses a QOM object link to allow the macio IDE object to > reference the DBDMA device, and then finally removes the global DBDMA_* > functions substituting them instead for QOM methods. > > Note: this patchset does not apply to master but on top of David's > ppc-for-2.11 branch since there are merge conflicts with my previous > patchset. Hopefully the Based-On line below is enough to keep patchew > happy, even though it wasn't the final version applied to the ppc-for-2.11 > branch. > > Signed-off-by: Mark Cave-Ayland <[email protected]> > Based-on: [email protected] > (ppc: more Mac-related fixups)
I've applied 1-5/7. There are a couple of details I'm not 100%
convinced on, but it's still better than what was there before. 6 & 7
I'm still thinking about.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
