On 09/19/2017 05:32 AM, Philippe Mathieu-Daudé wrote: > On 09/18/2017 07:42 PM, Eric Blake wrote: >> On 09/18/2017 05:13 PM, Philippe Mathieu-Daudé wrote: >>> Any magic cocci script to verify there aren't no more? >> >> I don't know if cocci can do it; checkpatch tries to check whether macro >> arguments are parenthesized, but even that's prone to missing things. I >> just spotted this particular one while reviewing a related patch. > > couldn't figure out. > > grep -E '^\s*#define\s+\w+\([^\)]+\)\s+.*\(\w+\)\w+' (no multiline) > found those unharmful: > > target/mips/dsp_helper.c:#define MIPSDSP_RETURN64_16(a, b, c, d) > (((uint64_t)a << 48) | \ > target/mips/dsp_helper.c:#define MIPSDSP_RETURN64_32(a, b) (((uint64_t)a > << 32) | (uint64_t)b) > include/hw/ppc/pnv_xscom.h:#define PNV_XSCOM_EX_CORE_BASE(base, i) (base > | (((uint64_t)i) << 24))
There's probably more, but I submitted patches for these two files as separate threads for qemu-trivial. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
