On 15.09.2017 15:07, Cornelia Huck wrote: > On Fri, 15 Sep 2017 13:57:40 +0200 > David Hildenbrand <[email protected]> wrote: > >> As an alternative, simply >> >> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c >> index 0f28ebd162..0f22efc3b6 100644 >> --- a/target/s390x/cpu_models.c >> +++ b/target/s390x/cpu_models.c >> @@ -195,6 +195,8 @@ bool s390_has_feat(S390Feat feat) >> return true; >> } >> } >> + if (feat == S390_FEAT_ZPCI) >> + return true; > > Move that out of the CONFIG_KVM #ifdef? >
Should not make a difference I think, cpu models are not shielded off for TCG I think (maybe we should fix that, but doesn't look that easy - they have no host model which would allow cpu->model = NULL). > (Also, we still have the issue with pci support :/ - depend on > pci_available?) hm .... > >> #endif >> return 0; >> } >> >> >> (this is also the way we handle other features without cpu model support >> -especially if cpu model support is disabled for older machines) > > Now that you mention cpu models (which are disabled on old machines), > the failure starts to look plausible :) > -- Thanks, David
