"Daniel P. Berrange" <[email protected]> wrote: > On Tue, Aug 08, 2017 at 06:26:17PM +0200, Juan Quintela wrote: >> Indicates the number of threads that we would create. By default we >> create 2 threads. >> # migrated and the destination must already have access to the >> # same backing chain as was used on the source. (since 2.10) >> # >> +# @x-multifd-threads: Number of threads used to migrate data in >> +# parallel. This is the same number that the >> +# number of sockets used for migration. >> +# The default value is 2 (since 2.11) > > The feature is called "multifd" but we're configuring number of threads, > with the implicit suggestion that number of threads == number of sockets. > > I wonder if its better to call this "x-multifd-connections" so that it > is explicit that we're determining the number of socket connections. > > This leaves room for adapting code to use a different number of threads, > but same number of sockets. eg with post-copy, there's potential to have > 2 threads for each socket (1 reading, 1 writing).
Changed to channels, is that ok for you? Later, Juan.
