On Tue, Sep 12, 2017 at 06:14:57PM +0200, Paolo Bonzini wrote: > On 12/09/2017 18:12, Daniel P. Berrange wrote: > > On Tue, Sep 12, 2017 at 05:52:18PM +0200, Paolo Bonzini wrote: > >> On 12/09/2017 12:46, Daniel P. Berrange wrote: > >>> Currently before submitting a series, devs should run checkpatch.pl > >>> across each patch to be submitted. This can be automated using a > >>> command such as: > >>> > >>> git rebase -i master -x 'git show | ./scripts/checkpatch.pl -' > >>> > >>> This is rather long winded to type, so this patch introduces a new > >>> flag '--branch' to checkpatch.pl which instructs it to check every > >>> patch on the current GIT branch. > >> > >> Great idea, though I'm not sure about having a default. And to keep it > >> easy to invoke, having a sole argument that ends with ".." might DWIM > >> and enable --branch too... > > > > I think it is beneficial to have a default, as I figure the majority > > of contributors are working on a branch that's rebased against master.. > > Half as many characters to type in the common case :-) > > With the DWIM option "--branch" and "master.." are exactly the same > length. :)
Oh hang on. I think I misunderstood what you suggested. I thought you meant 'checkpatch.pl --branch master..', but IIUC you actually mean 'checkpatch.pl master..' with no flag. That would work with me. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
