On 12 September 2017 at 15:19, Daniel P. Berrange <[email protected]> wrote: > My POV is that we should a) never check generated files into GIT, and > we should use the submodule in such a way that it is indistinguish > from the content of the submodule being part of the main GIT repo.
AFAICT this is impossible in that git submodules are broken (checking out a different commit in the top level repo doesn't check out the correct version of the submodule to go with it). We put up with it for our current uses of submodules because the submodule contents don't change very often... I agree that checking generated files into git is a bad idea if we can avoid it. thanks -- PMM
