On Fri, Sep 08, 2017 at 09:18:04AM -0700, Brandon Carpenter wrote: > I haven't seen this patch hit master yet and am about to submit a patch set > that is dependent on this one because it triggers the bug fixed by this > patch, causing a segmentation fault. Is it preferred that I include this > patch in that series with the Reviewed-by: tags or to just reference this > patch in the cover letter?
Yes, if you re-post the patch as part of a larger just, add any Reviewed-by tags to the commit message when you re-post. > On Tue, Jul 25, 2017 at 1:36 AM, Daniel P. Berrange <[email protected]> > wrote: > > On Mon, Jul 24, 2017 at 11:15:44AM -0700, Brandon Carpenter wrote: > > > Also set saved handle to zero when removing without adding a new > > > watch. > > > > > > Signed-off-by: Brandon Carpenter <[email protected]> > > > --- > > > ui/vnc-auth-vencrypt.c | 3 +++ > > > ui/vnc-ws.c | 6 ++++++ > > > ui/vnc.c | 4 ++++ > > > 3 files changed, 13 insertions(+) > > > > Reviewed-by: Daniel P. Berrange <[email protected]> > > > > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
