On Thu, Sep 07, 2017 at 06:05:37PM +0200, Paolo Bonzini wrote: > Il 02 set 2017 11:17 AM, "Aurelien Jarno" <aurel...@aurel32.net> ha scritto: > > On 2017-09-01 11:30, Eduardo Habkost wrote: > > i82374 is compiled in only on ppc and sh4, so I'm CCing the > > maintainers for those architectures. > > The i82374 device is not useful nor usable on SH4. It has just been > added in commit 85d3846a39 to be able to run the tests. > > > But that means that the patch is wrong and probably was not tested with > "make check". > > Eduardo's proposal is the right one. >
Great, I'll just add the missing details and resend the v2. Thanks for the review. Regards, -- Eduardo Otubo Senior Software Engineer @ RedHat
