On Tue, Aug 29, 2017 at 11:38:31AM +0100, Daniel P. Berrange wrote: > > > > So, IMHO, you should change all the callbacks to 'return TRUE' so that > > > > they keep the watch registered, and then explicitly call > > > > g_source_remove() > > > > passing the listen tag, when incoming migration starts. > > > > > > Yes this sounds better. Thanks! > > > > Hmm... when incoming migration starts, we are still in the handler of > > the listening gsource. I am not sure whether it's safe to remove the > > gsource in its own handlers. > > Yes, it should be safe to call g_source_remove from within the handler > itself.
Thanks for confirmation. Will post a new version soon. -- Peter Xu
