On Mon, Aug 14, 2017 at 01:06:42PM +0200, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, David Gibson wrote: > > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > > > These devices are found in some other ppc4xx cores too. > > Thanks for the quick review, hope more will follow for other patches too > maybe also from others. > > > Elsewhere in the series you moved things that were used elsewhere out > > of 405_uc, why not do that here as well? > > I've moved those because those devices needed to be modified extensively > while these two in this patch are used basically unchanged (they may not > even be completely correct for 460EX but seem to work well enough) so I've > left them here. I could add this explanation to the commit message or maybe > move them to ppc4xx_devs to make it clearer that they are not only used by > 405 emulation.
I think move them. Probably to their own file - I think smaller files
are usually going to be more readable than one big file with heaps of
4xx devices.
> > > Also add some more PLB registers for 460EX.
> >
> > Separate patch for that please, it's logically unrelated. Plus the
> > commit message should say what these registers are, where they appear,
> > why do we need them?
>
> OK. I don't really know what these registers are. I guess we need them
> because U-Boot or other guests poke them but they are only added to avoid
> the crash, not really emulated (just read zero, ignore write) for
> now.
Ok, so say that in the commit message.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
