On 11/22/2010 10:48 PM, Stefan Hajnoczi wrote:
> On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke <h...@suse.de> wrote:
> Looks good. If you send out another version of the patchset you might
> like to fix this nitpick:
>
>> + if (!r->io_header.iovec_count) {
>> + if (r->buflen != r->req.cmd.xfer) {
>> + if (r->buf != NULL)
>> + qemu_free(r->buf);
>
> qemu_free(NULL) is a nop so it's safe to drop the if (r->buf != NULL)
> check and just use qemu_free(r->buf) unconditionally. That's nice
> since it also fixes the if statement without curly braces.
>
Really?
qemu-malloc.c has:
void qemu_free(void *ptr)
{
trace_qemu_free(ptr);
free(ptr);
}
and 'free' doesn't normally do an error checking on the argument.
Am I missing something?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
h...@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
