On Tue, Aug 08, 2017 at 11:07:21AM +0100, Stefan Hajnoczi wrote: > On Fri, Aug 04, 2017 at 06:36:21PM -0300, Eduardo Habkost wrote: > > It makes command-line parsing and generation of help text much > > simpler. > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > scripts/qmp/qmp-shell | 61 > > +++++++++++++++++---------------------------------- > > 1 file changed, 20 insertions(+), 41 deletions(-) > > The minimum Python version is 2.6. The argparse module was introduced > in Python 2.7 so we cannot use it without increasing the minimum Python > version: > > https://docs.python.org/2.6/modindex.html > > I suggest holding off on this for now.
2.6 is the minimum Python version for what, exactly? Is it for building QEMU? Note that qmp-shell is a tool for developers, not required for building or running QEMU. People who really want to run qmp-shell on a python-2.6 system can still install argparse if they want to use qmp-shell. I could backport the code to optparse. But should we add code that relies on a deprecated module, if developers running Python 2.6 can install argparse? -- Eduardo
