On Mon, Jul 31, 2017 at 10:51:04AM +0200, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will: "Check if child process has terminated. > Set and return returncode attribute." > > Let's use the poll() to check whether the process is running and also > to get the updated process exit code, when the process is finished. > > Signed-off-by: Amador Pahim <apa...@redhat.com> > Reviewed-by: Fam Zheng <f...@redhat.com> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
This breaks the current version of shutdown(). Assuming that patch 6/7 will fix that (I didn't review patch 6/7 yet), this needs to be moved to the end of the series. -- Eduardo
