no-reply writes: > Hi, > This series seems to have some coding style problems. See output below for > more information:
> Subject: [Qemu-devel] [PATCH v7 0/5] hypertrace: Lightweight guest-to-QEMU > trace channel > Message-id: [email protected] > Type: series > === TEST SCRIPT BEGIN === > #!/bin/bash > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > exit $failed > === TEST SCRIPT END === > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/[email protected] -> > patchew/[email protected] > Switched to a new branch 'test' > 5dad7c93de hypertrace: Add guest-side user-level library > dcf9d9c7c7 hypertrace: [softmmu] Add QEMU-side proxy to "guest_hypertrace" > event > 4c041f724d hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" > event > 73796a3885 hypertrace: Add tracing event "guest_hypertrace" > 43fe7e2e2e hypertrace: Add documentation > === OUTPUT BEGIN === > Checking PATCH 1/5: hypertrace: Add documentation... > Checking PATCH 2/5: hypertrace: Add tracing event "guest_hypertrace"... > Checking PATCH 3/5: hypertrace: [*-user] Add QEMU-side proxy to > "guest_hypertrace" event... > Checking PATCH 4/5: hypertrace: [softmmu] Add QEMU-side proxy to > "guest_hypertrace" event... > Checking PATCH 5/5: hypertrace: Add guest-side user-level library... > WARNING: architecture specific defines should be avoided > #171: FILE: hypertrace/guest/common.c:84: > +#if !defined(CONFIG_USER_ONLY) && defined(__linux__) > ERROR: consider using qemu_strtoull in preference to strtoull > #191: FILE: hypertrace/guest/common.c:104: > + uint64_t vv = strtoull(v, &res, 16); > total: 1 errors, 1 warnings, 432 lines checked > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === > Test command exited with code: 1 I think both are false positives for this specific case. Cheers, Lluis
