On 07/28/2017 03:06 AM, Peter Xu wrote: > Introducing a new state "postcopy-paused", which can be used to pause a > postcopy migration. It is targeted to support network failures during > postcopy migration. Now when network down for postcopy, the source side > will not fail the migration. Instead we convert the status into this new > paused state, and we will try to wait for a rescue in the future. > > Signed-off-by: Peter Xu <[email protected]> > ---
You might want to use scripts/git.orderfile to put .json changes early
in your diffs (interface before implementation makes for easier reviews).
> +++ b/qapi-schema.json
> @@ -667,6 +667,8 @@
> #
> # @postcopy-active: like active, but now in postcopy mode. (since 2.5)
> #
> +# @postcopy-paused: during postcopy but paused. (since 2.10)
> +#
You've missed 2.10; this should be 2.11. Can this state occur without
any explicit request (ie. old clients may be confused by it), or do you
have to opt-in to a specific migration parameter to inform qemu that you
are aware of how to handle this state?
> # @completed: migration is finished.
> #
> # @failed: some error occurred during migration process.
> @@ -679,7 +681,8 @@
> ##
> { 'enum': 'MigrationStatus',
> 'data': [ 'none', 'setup', 'cancelling', 'cancelled',
> - 'active', 'postcopy-active', 'completed', 'failed', 'colo' ] }
> + 'active', 'postcopy-active', 'postcopy-paused',
> + 'completed', 'failed', 'colo' ] }
>
> ##
> # @MigrationInfo:
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
