First commit renames self._args to self.args. The leading underscore
represents that the variable is private and as such it should not be
accessed on instances. But that variable is the main API for inclusion
of Qemu command arguments, so the rename makes it public.
Next commits contain a series of fixes and cleanups to make sure we are
correctly trying to launch the VM and properly shutting it down. More
details about the changes in the individual commit messages.
Changes v1->v2:
- Style fixes to make checkpatch.pl happy.
- Rebased.
Changes v2->v3:
- Fix typo in patch 3 ("qemu.py: make 'args' public") commit message.
Changes v3->v4:
- Squash the 2 first commits since they are co-dependant.
- Cleanup launch() and shutdown().
- Reorder the commits, putting the rename of self._args first.
- Rebased.
Changes v4->v5:
- Break the cleanup commit into logical changes and include in the
commit messages the rationale for making them.
Amador Pahim (6):
qemu.py: make 'args' public
qemu.py: use poll() instead of 'returncode'
qemu.py: cleanup message on negative exit code
qemu.py: cleanup launch()
qemu.py: make sure shutdown() is called before launching again
qemu.py: include qemu command line and output on launch error
scripts/qemu.py | 72 ++++++++++++++++++++++++++++---------------
tests/qemu-iotests/iotests.py | 18 +++++------
2 files changed, 57 insertions(+), 33 deletions(-)
--
2.13.3
