On 18 July 2017 at 11:25, Daniel P. Berrange <[email protected]> wrote:
> The following changes since commit 6c6076662d98c068059983d411cb2a8987ba5670:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2017-07-14 12:16:09 +0100)
>
> are available in the git repository at:
>
> git://github.com/berrange/qemu tags/pull-qcrypto-2017-07-18-1
>
> for you to fetch changes up to 0e0fb56bcc8145d956bf527bfedc2be42bca101f:
>
> tests: crypto: add hmac speed benchmark support (2017-07-18 11:18:30 +0100)
>
> ----------------------------------------------------------------
> Merge crypto 2017/07/18 v1
>
> ----------------------------------------------------------------
Hi; I'm afraid this failed to build on clang (x86 Linux, FreeBSD,
OSX):
CC crypto/cipher.o
/home/petmay01/linaro/qemu-for-merges/crypto/cipher.c:177:9: error:
variable 'drv' is used uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (!ctx) {
^~~~
/home/petmay01/linaro/qemu-for-merges/crypto/cipher.c:192:30: note:
uninitialized use occurs here
cipher->driver = (void *)drv;
^~~
/home/petmay01/linaro/qemu-for-merges/crypto/cipher.c:177:5: note:
remove the 'if' if its condition is always true
if (!ctx) {
^~~~~~~~~~
/home/petmay01/linaro/qemu-for-merges/crypto/cipher.c:168:29: note:
initialize the variable 'drv' to silence this warning
QCryptoCipherDriver *drv;
^
= NULL
1 error generated.
and also
CC crypto/hmac.o
/home/petmay01/linaro/qemu-for-merges/crypto/hmac.c:103:9: error:
variable 'drv' is used uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (!ctx) {
^~~~
/home/petmay01/linaro/qemu-for-merges/crypto/hmac.c:116:28: note:
uninitialized use occurs here
hmac->driver = (void *)drv;
^~~
/home/petmay01/linaro/qemu-for-merges/crypto/hmac.c:103:5: note:
remove the 'if' if its condition is always true
if (!ctx) {
^~~~~~~~~~
/home/petmay01/linaro/qemu-for-merges/crypto/hmac.c:94:27: note:
initialize the variable 'drv' to silence this warning
QCryptoHmacDriver *drv;
^
= NULL
Looks like a false positive, I think :-(
thanks
-- PMM
