Peter Xu <[email protected]> wrote: > Abstract helper function to check migration capabilities (from the old > qmp_migrate_set_capabilities). Prepare to be used somewhere else. > > There is side effect on the change: when applying the capabilities, we > were skipping the invalid ones, but still applying the valid ones (if > they are provided in the same QMP request). After this refactoring, > we'll ignore all the capabilities if we detected invalid setup along the > way. However, I don't think it is a problem since general users should > not provide anything invalid after all. > > Signed-off-by: Peter Xu <[email protected]>
Reviewed-by: Juan Quintela <[email protected]> I think that the "caveat" that we used to set the valid capabilities in one message is just undefined behaviour. I preffer the new semmantics anyways.
