Re: [Qemu-devel] [PATCH v3 4/6] target/arm/translate: ensure gen_goto_tb sets exit flags

[Richard Henderson]

On 07/11/2017 07:59 AM, Alex Bennée wrote:
      if (use_goto_tb(s, dest)) {
          tcg_gen_goto_tb(n);
          gen_set_pc_im(s, dest);
          tcg_gen_exit_tb((uintptr_t)s->tb + n);
+        s->is_jmp = DISAS_TB_JUMP;
      } else {
          gen_set_pc_im(s, dest);
          gen_goto_ptr();
+        s->is_jmp = DISAS_JUMP;
      }

I think DISAS_TB_JUMP is appropriate for both cases.  When not using goto_tb, 
the jump is still static and we still chain to the next TB via goto_ptr.

Otherwise,

Reviewed-by: Richard Henderson <r...@twiddle.net>


r~