On Tue, Jul 04, 2017 at 13:12:02 +0200, Paolo Bonzini wrote:
> Reviewed-by: Richard Henderson <[email protected]>
> Signed-off-by: Paolo Bonzini <[email protected]>
> ---
> accel/tcg/translate-all.c | 5 +++++
> hmp-commands-info.hx | 4 ++++
> monitor.c | 2 ++
> 3 files changed, 11 insertions(+)
>
> diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> index 4c1d8c9..093207a 100644
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -1851,6 +1851,11 @@ void dump_exec_info(FILE *f, fprintf_function
> cpu_fprintf)
>
> tb_lock();
>
> + if (!tcg_enabled()) {
> + cpu_fprintf(f, "TCG not enabled\n");
> + return;
> + }
Sorry I missed this before it was merged, but:
- We're returning with tb_lock held
- This check is redundant; see b7da97eef ("monitor: Check whether TCG
is enabled before running the "info jit" code") which was merged
in April (hmp_info_jit is the only caller of dump_exec_info).
I suggest we get rid of the check, although moving it above tb_lock is
also OK with me.
Thanks,
Emilio
