Hi, This series seems to have some coding style problems. See output below for more information:
Message-id: [email protected] Type: series Subject: [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 079ea59 block: Move NVMe spec definitions to a separate header 28b0ea5 qemu-img: Map bench buffer 0c5fe62 block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap bb59e7c block: Introduce bdrv_dma_map and bdrv_dma_unmap be4dab1 block: Add VFIO based NVMe driver 74c0158 stubs: Add stubs for ram block API === OUTPUT BEGIN === Checking PATCH 1/6: stubs: Add stubs for ram block API... Checking PATCH 2/6: block: Add VFIO based NVMe driver... WARNING: line over 80 characters #191: FILE: block/nvme-vfio.c:133: + if (ioctl(s->device, VFIO_DEVICE_GET_REGION_INFO, &s->bar_region_info[index])) { WARNING: line over 80 characters #279: FILE: block/nvme-vfio.c:221: +static int nvme_vfio_pci_write_config(NVMeVFIOState *s, void *buf, int size, int ofs) ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #843: FILE: block/nvme.c:40: + volatile uint32_t *doorbell; ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #869: FILE: block/nvme.c:66: +typedef volatile struct { WARNING: line over 80 characters #1381: FILE: block/nvme.c:578: + error_setg(errp, "Timeout while waiting for device to reset (%ld ms)", WARNING: line over 80 characters #1410: FILE: block/nvme.c:607: + error_setg(errp, "Timeout while waiting for device to start (%ld ms)", total: 2 errors, 4 warnings, 1878 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/6: block: Introduce bdrv_dma_map and bdrv_dma_unmap... Checking PATCH 4/6: block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap... Checking PATCH 5/6: qemu-img: Map bench buffer... Checking PATCH 6/6: block: Move NVMe spec definitions to a separate header... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
