On Tue, 9 Nov 2010, Gerd Hoffmann wrote:
> The HDA bus supports up to 15 codecs, with addresses 0 ... 14.
> We get that wrong in two places:
>
> * When handing out addresses we accept address 15 as valid.
> * The bitmasks for two registers (WAKEEN and STATESTS) don't
> have bit 14 set.
>
> This patch fixes it.
>
I have applied and the reverted this one.
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> hw/intel-hda.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/intel-hda.c b/hw/intel-hda.c
> index 5e13dc3..b34b140 100644
> --- a/hw/intel-hda.c
> +++ b/hw/intel-hda.c
> @@ -56,7 +56,7 @@ static int hda_codec_dev_init(DeviceState *qdev, DeviceInfo
> *base)
> if (dev->cad == -1) {
> dev->cad = bus->next_cad;
> }
> - if (dev->cad > 15)
> + if (dev->cad >= 15)
> return -1;
Since there are no braces here.
--
mailto:av1...@comtv.ru
