On 06/01/2017 01:06 PM, Laszlo Ersek wrote: > On 06/01/17 15:03, Marc-André Lureau wrote: >> One way or another, the guest could communicate various dump info (via >> guest agent or vmcoreinfo device) and populate that structure. It can >> then be used to augment the dump with various details, as done in the >> following patch. >> >> Signed-off-by: Marc-André Lureau <[email protected]> >> --- >> include/sysemu/dump-info.h | 18 ++++++++++++++++++ >> dump.c | 3 +++ >> 2 files changed, 21 insertions(+) >> create mode 100644 include/sysemu/dump-info.h >> >> diff --git a/include/sysemu/dump-info.h b/include/sysemu/dump-info.h >> new file mode 100644 >> index 0000000000..d2378e15e2 >> --- /dev/null >> +++ b/include/sysemu/dump-info.h >> @@ -0,0 +1,18 @@ >> +#ifndef DUMP_INFO_H >> +#define DUMP_INFO_H
>> > > Can you please spell out, in the commit message, the reason for > introducing a new header file? (I suspect your reason, but it should be > documented explicitly.) Also, should you have a copyright header in the new file? And does MAINTAINERS cover it? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
