On 06/01/2017 07:41 AM, Marc-André Lureau wrote: No 0/2 cover letter?
> Suggested by Markus Armbruster: > > The gen_ prefix is awkward. Generated C should go through cgen() > exactly once (see commit 1f9a7a1). The common way to get this wrong is > passing a foo=gen_foo() keyword argument to mcgen(). I'd like us to > adopt a naming convention where gen_ means "something that's been piped > through cgen(), and thus must not be passed to cgen() or mcgen()". > Requires renaming gen_params(), gen_marshal_proto() and > gen_event_send_proto(). > > Signed-off-by: Marc-André Lureau <[email protected]> > --- > scripts/qapi.py | 2 +- > scripts/qapi-commands.py | 8 ++++---- > scripts/qapi-event.py | 12 ++++++------ > 3 files changed, 11 insertions(+), 11 deletions(-) > Reviewed-by: Eric Blake <[email protected]> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
