On Fri, May 19, 2017 at 03:14:35PM +0200, Laurent Vivier wrote: > On 19/05/2017 09:33, David Gibson wrote: > > On Fri, May 19, 2017 at 11:10:36AM +0530, Bharata B Rao wrote: > >> Introduce a new function unregister_savevm_live() to unregister the vmstate > >> handlers registered via register_savevm_live(). > >> > >> register_savevm() allocates SaveVMHandlers while register_savevm_live() > >> gets passed with SaveVMHandlers. During unregistration, we want to > >> free SaveVMHandlers in the former case but not free in the latter case. > >> Hence this new API is needed to differentiate this. > >> > >> This new API will be needed by PowerPC to unregister the HTAB savevm > >> handlers. > >> > >> Signed-off-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> > > > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > > > > I could take this through my tree, but it would need an ACK from Dave > > Gilbert or Juan Quintela. > > I cc: them for that.
Dave, Juan: his is fairly urgent, since it's a prereq for (sanely)
fixing a migration bug. Please let me know what I can do to expedite
review.
>
> Just a comment on the patch.
>
> Instead of introducing a new function, perhaps we can homogenize the use
> of register_savevm() by always providing a SaveVMHandlers pointer and
> never a couple of (SaveStateHandler, LoadStateHandler) so the
> unregister_save() has never to free se->ops?
Sounds reasonable to me. Again, Dave? Juan?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
