Pavel Dovgalyuk <[email protected]> wrote:
> From: Pavel Dovgalyuk <[email protected]>
>
> This patch does not allows saving/loading vmstate when
> replay events queue is not empty. There is no reliable
> way to save events queue, because it describes internal
> coroutine state. Therefore saving and loading operations
> should be deferred to another record/replay step.
>
> Signed-off-by: Pavel Dovgalyuk <[email protected]>
This functions have changed, see last series (but change is trivial from
monitor_printf to error_<something>)
> @@ -2083,6 +2084,12 @@ int save_vmstate(Monitor *mon, const char *name)
> Error *local_err = NULL;
> AioContext *aio_context;
>
> + if (!replay_can_snapshot()) {
> + monitor_printf(mon, "Record/replay does not allow making snapshot
> right now. "
> + "Try stopping at another step.\n");
> + return ret;
> + }
> +
To issue a savevm/loadvm the user don't have to stop qemu, so I think we
can improve the message to something les in both places?
"Try saving/loading later"?
Thanks, Juan.
