On 04/25/2017 01:51 AM, Cédric Le Goater wrote: > Currenlty, the code relies on the fact that open() handles NULL > filenames but that can cause an error with new clang:
POSIX doesn't require it to work. Linux is nice and gives you EFAULT, but there are systems where open(NULL) crashes with SIGSEGV. The clang warning is correct. > > hw/core/loader.c:67:15: runtime error: null pointer passed as argument 1, > which is declared to never be null > > Signed-off-by: Cédric Le Goater <c...@kaod.org> > --- > hw/ipmi/ipmi_bmc_sim.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
