On Thu, 04/20 22:15, Kevin Wolf wrote: > We test for the presence of perl and bc and save their path in the > variables PERL_PROG and BC_PROG, but never actually make use of them. > Remove the checks and assignments so qemu-iotests can run even when > bc isn't installed. > > Reported-by: Yash Mankad <yman...@redhat.com> > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > tests/qemu-iotests/common.config | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tests/qemu-iotests/common.config > b/tests/qemu-iotests/common.config > index 55527aa..1222e43 100644 > --- a/tests/qemu-iotests/common.config > +++ b/tests/qemu-iotests/common.config > @@ -75,18 +75,12 @@ _fatal() > exit 1 > } > > -export PERL_PROG="`set_prog_path perl`" > -[ "$PERL_PROG" = "" ] && _fatal "perl not found" > -
Then we should drop _readlink which is unused and uses perl too. Whether in this patch together or in a separate patch doesn't matter much, so: > export AWK_PROG="`set_prog_path awk`" > [ "$AWK_PROG" = "" ] && _fatal "awk not found" > > export SED_PROG="`set_prog_path sed`" > [ "$SED_PROG" = "" ] && _fatal "sed not found" > > -export BC_PROG="`set_prog_path bc`" > -[ "$BC_PROG" = "" ] && _fatal "bc not found" > - The bc part is nice! > export PS_ALL_FLAGS="-ef" > > if [ -z "$QEMU_PROG" ]; then > -- > 1.8.3.1 > > Reviewed-by: Fam Zheng <f...@redhat.com>
