On 04/18/2017 02:31 PM, Jeff Cody wrote: > On Tue, Apr 18, 2017 at 01:44:43PM -0500, Eric Blake wrote: >> On 04/18/2017 12:45 PM, Jeff Cody wrote: >>> For the tests that use the common.qemu functions for running a QEMU >>> process, _cleanup_qemu must be called in the exit function. >>> >>> If it is not, if the qemu process aborts, then not all of the droppings >>> are cleaned up (e.g. pidfile, fifos). >>>
>> >> Looks like you missed (at least?) 063 >> > > I did miss 156. But unless I am missing something, 063 does not use > common.qemu... Good point. 063 does litter, even on success, however: $ rm -rf scratch/ $ ./check -raw 063 ... $ ls scratch/ t.raw.raw1 One idea presented in an earlier thread was that common.rc should create a subdirectory per test (rather than all tests sharing scratch/), and then common.rc itself install the cleanup hook that wipes out the entire subdirectory (or maybe even add a command-line option to ./check to suppress wiping when it is desirable to debug a test failure by seeing the droppings left behind). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
