On 11.04.2017 15:58, Markus Armbruster wrote: > Max Reitz <[email protected]> writes: > >> Parsing the URI is not required to give us a scheme; uri->scheme may be >> NULL. >> >> Signed-off-by: Max Reitz <[email protected]> >> --- >> block/nfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/nfs.c b/block/nfs.c >> index 0816678307..0c7d5619fe 100644 >> --- a/block/nfs.c >> +++ b/block/nfs.c >> @@ -83,7 +83,7 @@ static int nfs_parse_uri(const char *filename, QDict >> *options, Error **errp) >> error_setg(errp, "Invalid URI specified"); >> goto out; >> } >> - if (strcmp(uri->scheme, "nfs") != 0) { >> + if (!uri->scheme || strcmp(uri->scheme, "nfs") != 0) { >> error_setg(errp, "URI scheme must be 'nfs'"); >> goto out; >> } > > Consider g_strcmp0().
Nice, thanks! Max
signature.asc
Description: OpenPGP digital signature
