On Thu, Mar 30, 2017 at 04:08:59PM +0100, Peter Maydell wrote: > On 28 March 2017 at 14:30, Philippe Mathieu-Daudé <[email protected]> wrote: > > should we add some comment like /* local variable used to avoid alignment > > issues */ in case later one find it clever to save few bytes on stack > > without reading git history? > > Hmm. There's no obvious single place where that could be put, > and I tend to think that if you're going to use packed structures > then "caution needed" is implicit. When we have these bug fixes > in then the plan is to add sparc to the set of standard merge > build tests, which will catch accidental reversions of this > fix (and eventually clang 4 will be more widespread which will > warn about this.) > > thanks > -- PMM
Let's apply this for now but I really don't remember why did we make it packed in the 1st place. -- MST
