On 03/02/2017 03:43 PM, Markus Armbruster wrote: > sd_snapshot_delete() should delete the snapshot whose ID matches > @snapshot_id and whose name matches @name. But that's not what it > does. If @snapshot_id is a valid ID, it deletes the snapshot with > that ID, else it deletes the snapshot with that name. It doesn't use > @name at all. Add suitable FIXME comments, so someone who actually > knows Sheepdog can fix it. > > Signed-off-by: Markus Armbruster <[email protected]> > --- > block/sheepdog.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >
If a sheepdog maintainer wants to rewrite this patch to avoid FIXME, I'm fine with that. But in the meantime, this doesn't change behavior, so it's safe for freeze. Reviewed-by: Eric Blake <[email protected]> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
