On Thu, Mar 02, 2017 at 03:41:33PM -0600, Eric Blake wrote: > On 03/02/2017 03:36 PM, [email protected] wrote: > > From: Ben Warren <[email protected]> > > > > This was crashing due to NULL-pointer dereference > > > > QMP Test case: > > ============== > > > > (QEMU) query-vm-generation-id > > {"error": {"class": "GenericError", "desc": "VM Generation ID device not > > found"}} > > > > HMP Test case: > > ============== > > virsh # qemu-monitor-command --hmp 3 info vm-generation-id > > VM Generation ID device not found > > > > Signed-off-by: Ben Warren <[email protected]> > > --- > > hmp.c | 4 +++- > > hw/acpi/vmgenid.c | 1 + > > 2 files changed, 4 insertions(+), 1 deletion(-) > > Reviewed-by: Eric Blake <[email protected]> > > However, hw/acpi/vmgenid.c is not part of the tree yet, so it may be > better to just respin the pull request to incorporate this into the > problematic patch that introduced the problem, rather than needing a > followup patch. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
The issue seems minor enough. I don't plan to re-spin unless there are more issues. -- MST
