On 3 December 2016 at 02:05, BALATON Zoltan <[email protected]> wrote:
> Signed-off-by: BALATON Zoltan <[email protected]>
It would be helpful to mention in the commit message that we don't
yet implement reset or vmstate and that those are coming in a
later commit.
(There is almost always something useful to say in a commit
message body; subject-line-only commit messages should
be the rare exception in my opinion.)
> +
> +static void sm501_sysbus_class_init(ObjectClass *klass, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> +
> + dc->realize = sm501_realize_sysbus;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> + dc->desc = "SM501 Multimedia Companion";
> + dc->props = sm501_sysbus_properties;
> +/* Note: pointer property "chr-state" may remain null, thus
> + * no need for dc->cannot_instantiate_with_device_add_yet = true;
> + */
This comment should be indented.
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
