On 28.02.2017 13:54, Kevin Wolf wrote: > Aborting on error in bdrv_append() isn't correct. This patch fixes it > and lets the callers handle failures. > > Test case 085 needs a reference output update. This is caused by the > reversed order of bdrv_set_backing_hd() and change_parent_backing_link() > in bdrv_append(): When the backing file of the new node is set, the > parent nodes are still pointing to the old top, so the backing blocker > is now initialised with the node name rather than the BlockBackend name. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 23 +++++++++++++++++------ > block/mirror.c | 9 ++++++++- > blockdev.c | 18 +++++++++++++++--- > include/block/block.h | 3 ++- > tests/qemu-iotests/085.out | 2 +- > 5 files changed, 43 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com> Thanks for leaving me the opportunity to write a patch which removes the bdrv_unref() from bdrv_append(). :-) Max
signature.asc
Description: OpenPGP digital signature
