Am 24.02.2017 um 16:22 schrieb Michal Marek:
> On 2017-02-24 15:51, no-re...@patchew.org wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
> [...]
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/1: target-s390x: Implement stfl and stfle...
>> ERROR: braces {} are necessary for all arms of this statement
>> #108: FILE: target/s390x/misc_helper.c:522:
>> + if (need <= len)
>> [...]
>> + else
>> [...]
>
> I was not aware of this coding style requirement. I will wait if I get
> more feedback from humans and resubmit.
>
Yes, QEMU (in contrast to the kernel) always requires {} for
if/else/for/while....
--
Thanks,
David
