On Thu, Jan 12, 2017 at 11:04:05AM +0100, Andrew Jones wrote: [...]
> > config=$TEST_DIR/unittests.cfg > > -rm -f test.log > > -printf "BUILD_HEAD=$(cat build-head)\n\n" > test.log > > + > > +rm -rf $unittest_log_dir.old > > +[ -d $unittest_log_dir ] && mv $unittest_log_dir $unittest_log_dir.old > > +mkdir $unittest_log_dir || exit 2 > > + > > +echo "BUILD_HEAD=$(cat build-head)" > $unittest_log_dir/SUMMARY > > + > > nit: to be 100% correct all the references to the log dir should have > "'s around them in order to handle spaces, or other shell ambiguous > characters, in the name. For example, mkdir $log_dir, where $log_dir > is "my tests" would create two directories, "my" and "tests" without > the quotes. Anyway, I'm not too worried about someone choosing a > weird log dir name, nor even changing it from the default. > > Isn't bash fun :-) It is, as long as it won't break my system... (Once I accidentally did a "rm -rf /lib" in Bash when I was still using FreeBSD... Bash became less funny since then ;-). I'll add them if I'm going to have another spin. [...] > Reviewed-by: Andrew Jones <drjo...@redhat.com> Thanks for reviewing! -- peterx
