Hi, Your series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH 00/17] add serial wacom tablet emulation (gsoc 2016) Type: series Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' ab71fe2 wctablet: implement ST and SP commands cfaa382 wctablet: update file comment 0bc544e wctablet: switch to new input interface ee75c1b wctablet: misc cleanups 378ba82 wctablet: drop DPRINTF, add trace events instead f316457 wctablet: drop timer, hook into chr->accept_input instead 06940e8 wctablet: revamp command parser. 3754fc0 wctablet: move init/detect sequence 40d2abf wctablet: add wctablet_shift_input 796d649 wctablet: drop debug code from wctablet_handler ceaea4f wctablet: operate on line speed 9600 055056b wctablet: track line speed, reset on speed changes 56034dc wctablet: strip leading \r + \n from buffer 7b59593 wctablet: drop wctablet_commands_names ea61171 wctablet: save all chars in the query buffer 8b3113b wctablet: add wctablet_queue_output helper de92a0f Add wctablet device === OUTPUT BEGIN === Checking PATCH 1/17: Add wctablet device... ERROR: do not use C99 // comments #90: FILE: backends/wctablet.c:61: +// Avaliable commands ERROR: do not use C99 // comments #92: FILE: backends/wctablet.c:63: + {0x0a, 0x53, 0x50, 0x0a, 0}, // \nSP\n ERROR: do not use C99 // comments #93: FILE: backends/wctablet.c:64: + {0x7e, 0x23, 0}, // ~# ERROR: do not use C99 // comments #94: FILE: backends/wctablet.c:65: + {0x0a, 0x54, 0x45, 0x0a, 0}, // \nTE\n ERROR: do not use C99 // comments #95: FILE: backends/wctablet.c:66: + {0x52, 0x45, 0x0a, 0}, // RE\n ERROR: do not use C99 // comments #96: FILE: backends/wctablet.c:67: + {0x41, 0x53, 0x31, 0x0a, 0}, // AS1\n ERROR: do not use C99 // comments #97: FILE: backends/wctablet.c:68: + {0x49, 0x43, 0x31, 0x0a, 0}, // IC1\n ERROR: do not use C99 // comments #98: FILE: backends/wctablet.c:69: + {0x4f, 0x43, 0x31, 0x0a, 0}, // OC1\n ERROR: do not use C99 // comments #99: FILE: backends/wctablet.c:70: + {0x49, 0x54, 0x88, 0x88, 0}, // IT3\r ERROR: do not use C99 // comments #100: FILE: backends/wctablet.c:71: + {0x53, 0x55, 0x88, 0x88, 0}, // SU3\n ERROR: do not use C99 // comments #101: FILE: backends/wctablet.c:72: + {0x50, 0x48, 0x31, 0x0a, 0}, // PH1\n ERROR: do not use C99 // comments #102: FILE: backends/wctablet.c:73: + {0x0d, 0x53, 0x54, 0x0d, 0}, // \rST\n ERROR: do not use C99 // comments #103: FILE: backends/wctablet.c:74: + {0x0d, 0x53, 0x50, 0x0d, 0}, // \rSP\r ERROR: do not use C99 // comments #104: FILE: backends/wctablet.c:75: + {0x54, 0x45, 0x0d, 0}, // TE\r ERROR: do not use C99 // comments #105: FILE: backends/wctablet.c:76: + {0x53, 0x50, 0x88, 0}, // SP\n ERROR: do not use C99 // comments #106: FILE: backends/wctablet.c:77: + {0x23, 0x41, 0x4c, 0x31, 0x0d, 0}, // #AL1\r ERROR: do not use C99 // comments #107: FILE: backends/wctablet.c:78: + {0x53, 0x54, 0x88, 0}, // ST\n ERROR: do not use C99 // comments #108: FILE: backends/wctablet.c:79: + {0x0d, 0x54, 0x53, 0x88, 0xd, 0}, // \rTS&\r ERROR: do not use C99 // comments #109: FILE: backends/wctablet.c:80: + {0x0d, 0x0a, 0x53, 0x50, 0x0d, 0x0a, 0}, // \r\nSP\r\n ERROR: do not use C99 // comments #110: FILE: backends/wctablet.c:81: + {0x7e, 0x23, 0x0d, 0} // ~#\r ERROR: do not use C99 // comments #113: FILE: backends/wctablet.c:84: +// Char strings with avaliable commands ERROR: do not use C99 // comments #136: FILE: backends/wctablet.c:107: +// Model string and config string ERROR: do not initialise globals to 0 or NULL #152: FILE: backends/wctablet.c:123: +int count = 0; ERROR: do not use C99 // comments #156: FILE: backends/wctablet.c:127: +// This structure is used to save private info for Wacom Tablet. ERROR: do not use C99 // comments #203: FILE: backends/wctablet.c:174: + // uint8_t codes[8] = { 0xa0, 0x0e, 0x06, 0x00, 0x13, 0x3b, 0x00 }; ERROR: do not use C99 // comments #204: FILE: backends/wctablet.c:175: + // uint8_t codes[8] = { 0xe0, 0x05, 0x6a, 0x00, 0x06, 0x64, 0x40 }; ERROR: do not use C99 // comments #205: FILE: backends/wctablet.c:176: + // uint8_t codes[8] = { 0xa0, 0x1c, 0x29, 0x00, 0x19, 0x1c, 0x00 }; ERROR: do not use C99 // comments #233: FILE: backends/wctablet.c:204: + int len, canWrite; // , i; ERROR: do not use C99 // comments #242: FILE: backends/wctablet.c:213: + // DPRINTF("-------- Write %2d: ", canWrite); ERROR: do not use C99 // comments #243: FILE: backends/wctablet.c:214: + // for (i = 0; i < len; i++) { ERROR: do not use C99 // comments #244: FILE: backends/wctablet.c:215: + // DPRINTF(" %02x", tablet->outbuf[i]); ERROR: do not use C99 // comments #245: FILE: backends/wctablet.c:216: + // } ERROR: do not use C99 // comments #246: FILE: backends/wctablet.c:217: + // DPRINTF("\n"); ERROR: space prohibited between function name and open parenthesis '(' #259: FILE: backends/wctablet.c:230: +static int wctablet_chr_write (struct CharDriverState *s, ERROR: do not use C99 // comments #272: FILE: backends/wctablet.c:243: + // DPRINTF("Receive: %.2x\n", c); ERROR: line over 90 characters #282: FILE: backends/wctablet.c:253: + memcpy(tablet->outbuf + tablet->outlen, WC_MODEL_STRING, WC_MODEL_STRING_LENGTH); ERROR: line over 90 characters #287: FILE: backends/wctablet.c:258: + memcpy(tablet->outbuf + tablet->outlen, WC_CONFIG_STRING, WC_CONFIG_STRING_LENGTH); ERROR: line over 90 characters #292: FILE: backends/wctablet.c:263: + memcpy(tablet->outbuf + tablet->outlen, WC_FULL_CONFIG_STRING, WC_FULL_CONFIG_STRING_LENGTH); WARNING: line over 80 characters #308: FILE: backends/wctablet.c:279: + codes[2] = ( ( ( WC_H4(input) & 0x7 ) ^ 0x5) << 4 ) | (WC_L4(input) ^ 0x7); ERROR: space prohibited after that open parenthesis '(' #308: FILE: backends/wctablet.c:279: + codes[2] = ( ( ( WC_H4(input) & 0x7 ) ^ 0x5) << 4 ) | (WC_L4(input) ^ 0x7); ERROR: space prohibited before that close parenthesis ')' #308: FILE: backends/wctablet.c:279: + codes[2] = ( ( ( WC_H4(input) & 0x7 ) ^ 0x5) << 4 ) | (WC_L4(input) ^ 0x7); ERROR: do not use C99 // comments #314: FILE: backends/wctablet.c:285: + // DPRINTF("-------- Command: %s\n", wctablet_commands_names[comm]); ERROR: space prohibited between function name and open parenthesis '(' #324: FILE: backends/wctablet.c:295: + g_free (chr->opaque); ERROR: space prohibited between function name and open parenthesis '(' #325: FILE: backends/wctablet.c:296: + g_free (chr); total: 43 errors, 1 warnings, 377 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/17: wctablet: add wctablet_queue_output helper... Checking PATCH 3/17: wctablet: save all chars in the query buffer... WARNING: line over 80 characters #32: FILE: backends/wctablet.c:243: + for (i = 0; i < len && tablet->query_index < sizeof(tablet->query) - 1; i++) { total: 0 errors, 1 warnings, 33 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/17: wctablet: drop wctablet_commands_names... Checking PATCH 5/17: wctablet: strip leading \r + \n from buffer... ERROR: do not use C99 // comments #20: FILE: backends/wctablet.c:63: + {0x53, 0x50, 0x0a, 0}, // SP\n ERROR: do not use C99 // comments #23: FILE: backends/wctablet.c:65: + {0x54, 0x45, 0x0a, 0}, // TE\n ERROR: do not use C99 // comments #33: FILE: backends/wctablet.c:73: + {0x53, 0x54, 0x0d, 0}, // ST\n ERROR: do not use C99 // comments #34: FILE: backends/wctablet.c:74: + {0x53, 0x50, 0x0d, 0}, // SP\r ERROR: do not use C99 // comments #41: FILE: backends/wctablet.c:79: + {0x54, 0x53, 0x88, 0xd, 0}, // TS&\r ERROR: do not use C99 // comments #42: FILE: backends/wctablet.c:80: + {0x53, 0x50, 0x0d, 0x0a, 0}, // SP\r\n total: 6 errors, 0 warnings, 47 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/17: wctablet: track line speed, reset on speed changes... Checking PATCH 7/17: wctablet: operate on line speed 9600... Checking PATCH 8/17: wctablet: drop debug code from wctablet_handler... Checking PATCH 9/17: wctablet: add wctablet_shift_input... Checking PATCH 10/17: wctablet: move init/detect sequence... Checking PATCH 11/17: wctablet: revamp command parser.... Checking PATCH 12/17: wctablet: drop timer, hook into chr->accept_input instead... Checking PATCH 13/17: wctablet: drop DPRINTF, add trace events instead... Checking PATCH 14/17: wctablet: misc cleanups... Checking PATCH 15/17: wctablet: switch to new input interface... Checking PATCH 16/17: wctablet: update file comment... Checking PATCH 17/17: wctablet: implement ST and SP commands... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
