Hi, Your series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI Message-id: [email protected] Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/[email protected] -> patchew/[email protected] - [tag update] patchew/[email protected] -> patchew/[email protected] - [tag update] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/148215768690.13973.9042496691140000163.stgit@bahia -> patchew/148215768690.13973.9042496691140000163.stgit@bahia * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] - [tag update] patchew/[email protected] -> patchew/[email protected] - [tag update] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 2d2326b hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off 3443a68 hw/isa/lpc_ich9: add broadcast SMI feature 3863642 hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg 12b2efd hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg file slots 5387420 fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma() c550b2c fw-cfg: turn FW_CFG_FILE_SLOTS into a device property 1f40c84 fw-cfg: support writeable blobs === OUTPUT BEGIN === Checking PATCH 1/7: fw-cfg: support writeable blobs... Checking PATCH 2/7: fw-cfg: turn FW_CFG_FILE_SLOTS into a device property... Checking PATCH 3/7: fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()... Checking PATCH 4/7: hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg file slots... ERROR: Macros with multiple statements should be enclosed in a do - while loop #126: FILE: include/hw/compat.h:4: +#define HW_COMPAT_2_8 \ + {\ + .driver = "fw_cfg_mem",\ + .property = "file_slots",\ + .value = stringify(0x10),\ + },{\ + .driver = "fw_cfg_io",\ + .property = "file_slots",\ + .value = stringify(0x10),\ + }, total: 1 errors, 0 warnings, 119 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/7: hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg... Checking PATCH 6/7: hw/isa/lpc_ich9: add broadcast SMI feature... Checking PATCH 7/7: hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
